fix(v1.1.5): added ws message with event 'all' for handling #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'spot.order_book' for handling
tiagosiebler
requested changes
Mar 28, 2025
Owner
tiagosiebler
left a comment
tiagosiebler
left a comment
There was a problem hiding this comment.
Small request in how we approach the fix. Please also increment the version number in the package.json, as it helps with the release process.
Contributor
Author
|
Hi. Edited, corrected and could be merged. Take a look pls. |
igorpronin
changed the title
tiagosiebler
previously approved these changes
Apr 1, 2025
Owner
tiagosiebler
left a comment
tiagosiebler
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the fix!
tiagosiebler
reviewed
Apr 1, 2025
tiagosiebler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added messages to handle to avoid "Unhandled string event type" error
PR Checklist
As part of the PR, make sure you have:
npm installruns without issue.npm run buildruns without issue.