refactor: extract duplicated code getClientIp#234
Open
k05j wants to merge 1 commit intotiagozip:mainfrom
Open
Conversation
* getting the client ip was duplicated in cap.js and ratelimit.js which meant that if it needs changes in the future we would have to change two functions that effectively do the same * introduced new file ip_extraction that exports the function getClientIp, the function is then imported in cap.js and ratelimit.js * dropped one warning in ratelimiter that the IP could not be found in the header because it is duplicated, as we log "Unable to determine client IP" anyways if it cannot be found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the duplication in code while reading through and thought it would help in the future.