[codex] Exit top-level loop on stdin EOF - #49
Draft
juangrukat wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
When Shen is run with piped stdin or redirected file input, EOF becomes
error: empty stream. The top-level loop traps that error, prints it, and then recurses, which causes an endless stream oferror: empty streammessages after the input file has finished.This treats that EOF condition as a clean termination signal instead.
Validation
go test ./...make shenprintf '(+ 1 2)\n' | ./shen./shen < /Users/kat/Desktop/a/tests.shen