ksud: fix all warnings #3097
Open
ksud: fix all warnings #3097
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Rust compiler warnings in the ksud codebase by adding appropriate conditional compilation attributes and refactoring variable initialization patterns.
- Added
#[cfg_attr(not(target_os = "android"), allow(dead_code))]to VERSION_CODE constant that's only used in Android-specific modules - Added
#[cfg_attr(not(target_os = "android"), allow(unused_variables))]tofind_boot_imagefunction whose parameters are primarily used in Android builds - Refactored
bootdevicevariable infind_boot_imagefrom mutable to immutable with conditional initialization
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| userspace/ksud/src/defs.rs | Suppresses dead code warning for VERSION_CODE constant on non-Android platforms |
| userspace/ksud/src/boot_patch.rs | Adds unused variable suppression for non-Android builds and refactors bootdevice initialization to be immutable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ksud-extra warnings, edits welcomed.