ksud: don't panic on a broken zip in get_zip_uncompressed_size - #3591
Open
palazik wants to merge 1 commit into
Open
ksud: don't panic on a broken zip in get_zip_uncompressed_size#3591palazik wants to merge 1 commit into
palazik wants to merge 1 commit into
Conversation
by_index() was unwrapped, so a zip with an entry we can't read (e.g. a truncated or otherwise broken archive handed to `module install`) takes down the whole ksud process instead of surfacing an error. The function already returns Result, so just use `?` and sum in a loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_zip_uncompressed_sizeiterates the archive withby_index(i).unwrap(). If any entry can't be read theunwrap()panics and the whole ksud process dies.This is reachable from
module install: hand it a truncated or corrupted zip and instead of a clean "failed to read module" error you get a panic.Since the function already returns
Result<u64>, the simple fix is to propagate the error with?:No behavior change for valid archives.