Skip to content

uefi-sct/SctPkg: Fix copy mem build error #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baranee
Copy link

@baranee baranee commented Dec 11, 2024

Use SctCopyMem instead of EfiCommonLibCopyMem

Signed-off-by: Anbazhagan Baraneedharan [email protected]

@baranee
Copy link
Author

baranee commented Dec 12, 2024

@edhay For some reason, am not able to add reviewers on this PR.

@edhay
Copy link
Collaborator

edhay commented Dec 17, 2024

Hi @baranee ,

Okay. Could you please raise this issue and submit the patch at the edk2-test mailing list.
https://edk2.groups.io/g/devel/messages
The patch shall be reviewed in the mailing list.

Also please raise a bug in
https://bugzilla.tianocore.org/buglist.cgi?component=UEFI-SCT&list_id=32587&product=EDK2%20Test&resolution=---

Please feel free to contact me for any assistance.

Reference: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers

@edhay edhay requested review from edhay and gaojiebyo as code owners January 31, 2025 19:23
@edhay
Copy link
Collaborator

edhay commented Feb 6, 2025

Hi @baranee, What is the build error seen?
Also please raise this issue and submit patch in the edk2 message group.

@baranee
Copy link
Author

baranee commented Feb 6, 2025

@edhay Undefined error on EfiCommonLibCopyMem. Since bugzilla.tianocore.org is down for a while, I thought it's only thru PR at this point.
SctPkg\Library\SctLib\Hob.c(388): error C2220: the following warning is treated as an error SctPkg\Library\SctLib\Hob.c(388): warning C4013: 'EfiCommonLibCopyMem' undefined; assuming extern returning int

@chetan-rathore
Copy link

@edhay and @baranee,

I also observe this issue on cross compiliinf, with arm 14.2 toolchain (arm-gnu-toolchain-14.2.rel1-x86_64-aarch64-none-linux-gnu), but same is not observed with 13.2 toolchain (arm-gnu-toolchain-13.2.Rel1-x86_64-aarch64-none-linux-gnu)

@baranee
Copy link
Author

baranee commented Mar 4, 2025

@chetan-rathore Thanks for confirming similar issue in arm tool chain build. @edhay any other process needs to be followed to merge this PR?

@luigix25
Copy link

I have the same problem here, this actually fixes it :)

saqwed added a commit to saqwed/myedk2 that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants