uefi-sct/SctPkg: Fixes "Unsupported target architecture X64 !" #245
Conversation
fixes: tianocore#244 Signed-off-by: Dongyan Qian <[email protected]>
| if [ X"$CROSS_COMPILE_64" != X"" ]; then | ||
| TEMP_CROSS_COMPILE="$CROSS_COMPILE_64" | ||
| else | ||
| TEMP_CROSS_COMPILE=x86_64-redhat-linux- |
There was a problem hiding this comment.
Query: Is this a standard cross-compiler for x64?
There was a problem hiding this comment.
The x86_64-redhat-linux- prefix is the standard cross-compiler prefix you’ll find on RHEL/CentOS systems.
On Debian/Ubuntu, you can simply set: export CROSS_COMPILE_64=x86_64-linux-gnu- and the script will prefer that value.
If you’d rather make the default more distribution-agnostic, you could change the built-in default tox86_64-linux-gnu-and let anyone with special requirements override it via CROSS_COMPILE_64
root@qdy: x86_64-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=x86_64-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-linux-gnu/13/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 13.3.0-6ubuntu2 24.04' --with-bugurl=file:///usr/share/doc/gcc-13/README.Bugs --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-13 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/libexec --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-libstdcxx-backtrace --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --enable-cet --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-13-fG75Ri/gcc-13-13.3.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-13-fG75Ri/gcc-13-13.3.0/debian/tmp-gcn/usr --enable-offload-defaulted --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu --with-build-config=bootstrap-lto-lean --enable-link-serialization=2
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04)
Should I replace x86_64-redhat-linux- with x86_64-linux-gnu-? Looking forward to your comments. @edhay
|
@cgjertsen : Requesting your review on this PR. |
fixes: #244