Skip to content

DynamicTablesPkg: Add CEDT table generation #11010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 25, 2025
Merged

DynamicTablesPkg: Add CEDT table generation #11010

merged 4 commits into from
May 25, 2025

Conversation

NicholasGraves
Copy link
Contributor

Description

  • Add namespace objects for CEDT table generation.

  • Add generator to create CEDT table

  • Add unit tests for generator.

  • Breaking change?

    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.

  • Impacts security?

    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.

  • Includes tests?

    • unit tests

How This Was Tested

  • unit tests
  • qemu test

Integration Instructions

N/A

@github-actions github-actions bot added the impact:testing This contribution includes tests such as unit and/or integration tests. label Apr 25, 2025
@NicholasGraves NicholasGraves force-pushed the cxl-namespace-obj-upstream branch 13 times, most recently from 0e2342c to 1a65675 Compare May 1, 2025 21:14
pierregondois
pierregondois reviewed May 5, 2025
View reviewed changes
Copy link
Contributor

@pierregondois pierregondois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Nick,
Thanks for the PR, I added a few comments.
I haven't checked the tests yet, but would it be possible to place them in another patch/commit ?

Regards,
Pierre

@NicholasGraves NicholasGraves force-pushed the cxl-namespace-obj-upstream branch 4 times, most recently from 7ce03b2 to 79ea2ab Compare May 6, 2025 19:54
@NicholasGraves
Copy link
Contributor Author

Hello Nick, Thanks for the PR, I added a few comments. I haven't checked the tests yet, but would it be possible to place them in another patch/commit ?

Regards, Pierre

Done, moved tests to a separate commit.

pierregondois
pierregondois reviewed May 12, 2025
View reviewed changes
Copy link
Contributor

@pierregondois pierregondois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Nicholas,
I should have answered + I went through the test file this time

@pierregondois
Copy link
Contributor

Also, would it be possible to run the following command and fix the reported issues ?
There might be initialization steps before running the command, available in: DynamicTablesPkg/Readme.md

stuart_ci_build -c .pytool/CISettings.py TOOL_CHAIN_TAG=GCC5 -a AARCH64 -p DynamicTablesPkg

@NicholasGraves NicholasGraves force-pushed the cxl-namespace-obj-upstream branch 2 times, most recently from a45457f to 0087545 Compare May 12, 2025 21:00
@NicholasGraves
Copy link
Contributor Author

Also, would it be possible to run the following command and fix the reported issues ? There might be initialization steps before running the command, available in: DynamicTablesPkg/Readme.md

stuart_ci_build -c .pytool/CISettings.py TOOL_CHAIN_TAG=GCC5 -a AARCH64 -p DynamicTablesPkg

Fixed everything except an error about GoogleTestLib not being used in LibraryClasses, but removing GoogleTestLib breaks the tests.

@NicholasGraves NicholasGraves force-pushed the cxl-namespace-obj-upstream branch 3 times, most recently from 39c223d to 2720dbf Compare May 13, 2025 17:25
pierregondois
pierregondois approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@pierregondois pierregondois left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the modifications !
The PR is ok for me, but we can only merge it after the 23/05, cf: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning

samimujawar
samimujawar approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@samimujawar samimujawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion to add a comment for the macro definition.
Otherwise this PR looks good to me.

@NicholasGraves
DynamicTablesPkg: Add CXL CEDT namespace objects
8b9eec0 
- Add objects for CEDT CHBS and CEDT CFMWS. These describe CXL host
  bridges and CXL fixed memory windows, respectively.

Signed-off-by: Nick Graves <[email protected]>
@NicholasGraves
DynamicTablesPkg: Add CEDT generator
4667af1 
- Generate CEDT table from ConfigurationManager objects.
- Only CHBS and CFMWS sub-tables are supported currently.

Signed-off-by: Nick Graves <[email protected]>
@NicholasGraves
DynamicTablesPkg: Add CEDT generator tests
1d98198 
- Add unit tests for CEDT generator.

Signed-off-by: Nick Graves <[email protected]>
@NicholasGraves NicholasGraves force-pushed the cxl-namespace-obj-upstream branch from 2720dbf to 1d98198 Compare May 22, 2025 16:57
@NicholasGraves
Copy link
Contributor Author

Minor suggestion to add a comment for the macro definition. Otherwise this PR looks good to me.

Good suggestion, I added a comment. Anything else to address? If not, can we target a merge early next week?

@samimujawar samimujawar added the push Auto push patch series in PR if all checks pass label May 25, 2025
@mergify mergify bot merged commit 85a5bd4 into tianocore:master May 25, 2025
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samimujawar samimujawar samimujawar approved these changes

@pierregondois pierregondois pierregondois approved these changes

Assignees
No one assigned
Labels
impact:testing This contribution includes tests such as unit and/or integration tests. push Auto push patch series in PR if all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicholasGraves @pierregondois @samimujawar