MdeModulePkg: Correct CoreRemoveDebugImageInfoEntry() #11019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xypron
force-pushed
the
CoreRemoveDebugImageInfoEntry
branch
from
19acbdd to
c40fbde
Compare
The UEFI specification does not allow NULL pointers in the EFI Debug Info Table. The TableSize field in the EFI Debug Info Table Header must always match the array size of the EFI Debug Info Table. Instead of creating a NULL entry when removing an entry, move the tail of the EFI Debug Info Table one slot to the front. Signed-off-by: Heinrich Schuchardt <[email protected]>
xypron
force-pushed
the
CoreRemoveDebugImageInfoEntry
branch
from
c40fbde to
3618656
Compare
|
Ironically, I put up a PR to fix this same issue last week: #11013. Can you test with that and confirm it fixes the issue you are seeing? I also updated the Add function to clean it up |
Your patch solves the deviation from the UEFI specification. Having the entries in load order would be convenient for debugging, but this feature was neither provided by the previous implementation nor is it required by the UEFI specification. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The UEFI specification does not allow NULL pointers in the EFI Debug Info Table. The TableSize field in the EFI Debug Info Table Header must always match the array size of the EFI Debug Info Table.
Instead of creating a NULL entry when removing an entry, move the tail of the EFI Debug Info Table one slot to the front.
Breaking change?
no
Impacts security?
no
Includes tests?
no
How This Was Tested
https://lore.kernel.org/u-boot/[email protected]/T/#u
has a patch for U-Boot to create a test binary.
Integration Instructions
N/A