IntelFsp2Pkg/CacheLib: Make integer width consistent in loop condition #11025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly casts `mFixedMtrrTable[MsrNum].Length` to resolve a `comparison-with-wider-type` CodeQL error. https://codeql.github.com/codeql-query-help/cpp/cpp-comparison-with-wider-type/ Signed-off-by: Michael Kubacki <[email protected]>
tianocore-assign-reviewers
bot
requested review from
AshrafAliS,
ChaselChiu,
lzeng14,
nate-desimone and
tedkuo1
ChaselChiu
reviewed
May 2, 2025
| @@ -328,7 +328,7 @@ ProgramFixedMtrr ( | |||
| return EFI_DEVICE_ERROR; | |||
| } | |||
|
|
|||
| for ( ; ((ByteShift < 8) && (*Len >= mFixedMtrrTable[MsrNum].Length)); ByteShift++) { | |||
| for ( ; ((ByteShift < 8) && (*Len >= (UINT64)mFixedMtrrTable[MsrNum].Length)); ByteShift++) { | |||
There was a problem hiding this comment.
enlarging the data type might bring some "unwanted data" into the "(UINT64) mFixedMtrrTable[MsrNum].Length"?
How about changing it like below which looks safer?
mFixedMtrrTable[MsrNum].Length <= (UINT32) *Len
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicitly casts
mFixedMtrrTable[MsrNum].Lengthto resolve acomparison-with-wider-typeCodeQL error.https://codeql.github.com/codeql-query-help/cpp/cpp-comparison-with-wider-type/
How This Was Tested
Integration Instructions
N/A