ArmPkg: StMM: Use x24 register to store stack address #11027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
leiflindholm and
samimujawar
LeviYeoReum
approved these changes
Jun 2, 2025
mgamal
force-pushed
the
stmm_fix_stack_address_register
branch
from
7fb3e89 to
976ff4a
Compare
Now that the use of 18 registers for FF-A is supported. Registers from x0-x17 can be used by FF-A to return call results. StMM also uses registers x19-x23 to store SPMC boot information. Use the x24 register to store the stack address instead of x12 to avoid it being clobbered by FF-A calls. Signed-off-by: Mohamed Gamal Morsy <[email protected]>
mgamal
force-pushed
the
stmm_fix_stack_address_register
branch
from
976ff4a to
8f92f67
Compare
mgamal
changed the title
samimujawar
approved these changes
Jun 25, 2025
leiflindholm
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that the use of 18 registers for FF-A is supported. Registers from x0-x17 can be used by FF-A to return call results. StMM also uses registers x19-x23 to store SPMC boot information.
Use the x24 register to store the stack address instead of x12 to avoid it being clobbered by FF-A calls.
How This Was Tested
Tested running rust-spmc as an EL-1 SPMC
Integration Instructions
N/A