MdeModulePkg: Correct Usb Mouse Z for absolute pointer. #11030
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.usb.org/sites/default/files/hid1_11.pdf Appendix B, B.2 Protocol 2 (Mouse) details the information returned by a usb mouse HID. bytes 3..n are specific to the device, but are used by absolute pointer devices to return a z axis. Prior to this change, the existing code was reusing the X value for the Z axis, which was incorrect. For usb devices which do not return enough data for a z axis, this change will be a no-op. Signed-off-by: Aaron Pop <[email protected]>
apop5
force-pushed
the
personal/apop5/absolutepointer
branch
from
cac39f9 to
b6d406d
Compare
|
How was this tested? |
mdkinney
approved these changes
May 5, 2025
The details of the testing of this have been lost, but its been used since 2018 in platforms with absolute pointers (usb touch screens) since then. |
|
@lgao4 This PR was submitted before soft freeze and has passed CI. Please review. I approve this for edk2-stable202505. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://www.usb.org/sites/default/files/hid1_11.pdf Appendix B, B.2 Protocol 2 (Mouse) details the information returned by a usb mouse HID.
bytes 3..n are specific to the device, but are used by absolute pointer devices to return a z axis.
Prior to this change, the existing code was reusing the X value for the Z axis, which was incorrect.
For usb devices which do not return enough data for a z axis, this change will be a no-op.
for reference, the dxemouse can also be viewed to show that for "z axis" is it referencing the 3rd byte of returned data.
How This Was Tested
N/A
Integration Instructions
No integration necessary.