Skip to content

Add ability to list attributes for an element #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nakajima wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ability to list attributes for an element #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/Kanna/Kanna.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ XMLElement
*/
public protocol XMLElement: SearchableNode {
var parent: XMLElement? { get set }
var attributes: [String: String?] { get }
subscript(attr: String) -> String? { get set }

func addPrevSibling(_ node: XMLElement)
Expand Down
19 changes: 19 additions & 0 deletions Sources/Kanna/libxmlHTMLNode.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,25 @@ final class libxmlHTMLNode: XMLElement {
}
}

var attributes: [String : String?] {
var result: [String: String?] = [:]
var attribute = nodePtr.pointee.properties

while let attr = attribute {
let mem = attr.pointee
let prefix = mem.ns.flatMap { $0.pointee.prefix.string }
let attributeName = [prefix, mem.name.string].compactMap { $0 }.joined(separator: ":")

if let children = mem.children {
result[attributeName] = libxmlGetNodeContent(children)
}

attribute = attr.pointee.next
}

return result
}

init(document: XMLDocument?, docPtr: xmlDocPtr) throws {
self.weakDocument = document
self.docPtr = docPtr
Expand Down
12 changes: 12 additions & 0 deletions Tests/KannaTests/KannaTutorialsTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,18 @@ class KannaTutorialsTests: XCTestCase {

XCTAssert(doc.body?.toHTML == TestModifyHTML)
}

func testListAttributes() throws {
let html = """
<body>
<h2 class="show-title" data-hello="world">Three's Company</h2>
</body>
"""

let document = try HTML(html: html, encoding: .utf8)
let h2 = document.at_css("h2")!
XCTAssertEqual(["class": "show-title", "data-hello": "world"], h2.attributes)
}
}

extension KannaTutorialsTests {
Expand Down