Skip to content

make sql user custom role optional #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shiyuhang0 merged 3 commits into from
Mar 9, 2026
Merged

make sql user custom role optional #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39a4a85
update sql user
shiyuhang0 Mar 9, 2026
85b4473
terraform generate
shiyuhang0 Mar 9, 2026
7b69b3b
terraform generate
shiyuhang0 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/resources/sql_user.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ resource "tidbcloud_sql_user" "example" {

### Required

- `builtin_role` (String) The built-in role of the sql user, available values [role_admin, role_readonly, role_readwrite]. The built-in role [role_readonly, role_readwrite] must start with user_prefix for serverless cluster
- `cluster_id` (String) The ID of the cluster.
- `password` (String, Sensitive) The password of the user.
- `user_name` (String) The name of the user. The user name must start with user_prefix for serverless cluster

### Optional

- `auth_method` (String) The authentication method of the user. Only mysql_native_password is supported.
- `builtin_role` (String) The built-in role of the sql user, available values [role_admin, role_readonly, role_readwrite]. The built-in role [role_readonly, role_readwrite] must start with user_prefix for serverless cluster
- `custom_roles` (List of String) The custom roles of the user.
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ github.com/bufbuild/protocompile v0.14.1 h1:iA73zAf/fyljNjQKwYzUHD6AD4R8KMasmwa/
github.com/bufbuild/protocompile v0.14.1/go.mod h1:ppVdAIhbr2H8asPk6k4pY7t9zB1OU5DoEw9xY/FUi1c=
github.com/c4pt0r/go-tidbcloud-sdk-v1 v0.0.0-20240415110020-a27efb454da5 h1:QdHeP1q1E2dv5fWuIkQNNmHr5vm/+jlYPK10TR3iV1M=
github.com/c4pt0r/go-tidbcloud-sdk-v1 v0.0.0-20240415110020-a27efb454da5/go.mod h1:mCYM+u/09SNW15Ed+qn+JeuxkK9dr+Fq0DZk+kUkB74=
github.com/cespare/xxhash/v2 v2.3.0 h1:UL815xU9SqsFlibzuggzjXhog7bL6oX9BbNZnL2UFvs=
github.com/cespare/xxhash/v2 v2.3.0/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs=
github.com/cloudflare/circl v1.6.3 h1:9GPOhQGF9MCYUeXyMYlqTR6a5gTrgR/fBLXvUgtVcg8=
github.com/cloudflare/circl v1.6.3/go.mod h1:2eXP6Qfat4O/Yhh8BznvKnJ+uzEoTQ6jVKJRn81BiS4=
github.com/cyphar/filepath-securejoin v0.4.1 h1:JyxxyPEaktOD+GAnqIqTf9A8tHyAG22rowi7HkoSU1s=
Expand Down
2 changes: 1 addition & 1 deletion internal/provider/sql_user_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func (r *sqlUserResource) Schema(_ context.Context, _ resource.SchemaRequest, re
},
"builtin_role": schema.StringAttribute{
MarkdownDescription: "The built-in role of the sql user, available values [role_admin, role_readonly, role_readwrite]. The built-in role [role_readonly, role_readwrite] must start with user_prefix for serverless cluster",
Required: true,
Optional: true,
},
"custom_roles": schema.ListAttribute{
MarkdownDescription: "The custom roles of the user.",
Expand Down