-
-
Notifications
You must be signed in to change notification settings - Fork 3
chore(ios): workflow update #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I've fixed the optional unwrapping in the latest commit (without force-unwrapping), but we can take your CI changes! Can you rebase your PR please? |
|
The workflow didn't work correctly. So I have to redo them and add the android version too. Will do a new one for that |
|
It's nearly there - iOS is mainly fixed (except some linting errors that are now fixed on master) and Android probably just needs the cache/v4 update as well. |
|
Ah sorry, didn't see the update 😄 |
|
I'll do some more tests tomorrow. The Android emulator is not starting (ReactiveCircus/android-emulator-runner#324 (comment)) and iOS is failing because of a switflint error: |
Only applied the Xcode recommendations to make it build again, don't know if this is correct!
appcelerator.ble-iphone-3.0.0.zip