You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Warnings
⚠️
Tests have failed, see below for more information.
⚠️
There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖
✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖
❌ 3 tests have failed
There are 3 tests failing and 1157 skipped out of 20838 total tests.
📖
🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
#forwardGeocoder() works via callback argument (12)
5.013
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
at Assertion.value (/node_modules/should/cjs/should.js:356:9)
at Geolocation.<anonymous> (/ti.geolocation.test.js:585:32)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work in progress / PoC
Snapping for ListView/TableView. Needs some more properties and documentation. But it is possible to add snapping to a ListView/TableView.
20211115_210628_edit.mp4
JIRA: https://jira.appcelerator.org/browse/[TICKET]