-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(android): more attributedString link features #13928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
m1ga
wants to merge
8
commits into
main
Choose a base branch
from
231003_link_underline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+72
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
reviewed
Oct 12, 2023
android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUILabel.java
Show resolved
Hide resolved
m1ga
commented
Apr 6, 2025
m1ga
commented
Oct 1, 2025
m1ga
commented
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the attributedString link is not very flexible in terms of color and removing the underline.
This PR adds two new features:
linkColorfor the label: allows to set the color of the autoLink or attributedString link. Note: currently we can use another attributeTi.UI.ATTRIBUTE_FOREGROUND_COLORto color the link. This works for both Android and iOS. But there is not way to color a link withautoLink(Android only). So we won't need iOS parity for this property.a new attribute
underlinein the attributedString that can be used in combination withtype: Titanium.UI.ATTRIBUTE_LINKto remove the underline from the link