Simplify middleware - #33
Merged
Merged
Conversation
josevalim
approved these changes
Oct 9, 2025
josevalim
left a comment
josevalim
left a comment
Contributor
There was a problem hiding this comment.
I like it. But if we use the app router we will need a separate approach, but I guess that’s fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See README changes for the simplified instructions.
In the request handler, we look at the original URL (from before middleware rewrite), therefore it doesn't really matter at which path the handler itself resides. This means:
Instead of
pages/api/tidewave/[...all].ts, we can have a simpler routepages/api/tidewave.tsand it works the same way. This file is slightly less annoying to create (compared to[...all]).The middleware can redirect to a fixed route in all cases, which streamlines the code.
I also added a check to make sure that if someone accesses
/api/tidewavewe show a message to clarify.I don't see any downsides, WDYT?