Enforce empty dots where applicable

grid_regular.parameters() doesn't enforce empty dots but should. Let's do a check for those situations across the package.

dials/R/grids.R

Lines 64 to 73 in a8a8e92

    
           grid_regular.parameters <- function( 
        
             x, 
        
             ..., 
        
             levels = 3, 
        
             original = TRUE, 
        
             filter = NULL 
        
           ) { 
        
             # test for NA and finalized 
        
             # test for empty ... 
        
             params <- x$object

use `check_param()` for grid functions

On encode_unit():

make_max_entropy_grid() and make_latin_hypercube_grid() call encode_unit() on a parameter set which may contain qual and quant parameters like this:

dials/R/space_filling.R

Lines 492 to 499 in e564926

    
           # Get back to parameter units 
        
           sf_grid <- map2( 
        
             params, 
        
             sf_grid, 
        
             encode_unit, 
        
             direction = "backward", 
        
             original = original 
        
           )

which means that original gets passed to either method and encode_unit.qual_param() currently swallows it silently.

Navigation Menu

Repository navigation

Enforce empty dots where applicable #434

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	grid_regular.parameters <- function(
	x,
	...,
	levels = 3,
	original = TRUE,
	filter = NULL
	) {
	# test for NA and finalized
	# test for empty ...
	params <- x$object

	# Get back to parameter units
	sf_grid <- map2(
	params,
	sf_grid,
	encode_unit,
	direction = "backward",
	original = original
	)

Enforce empty dots where applicable #434

Description

Activity

hfrick commented on Apr 8, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions