Implement leap_year() in C
#1189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the fastymd package hitting CRAN recently. One of its features is fast leap year calculations, which made me wonder how lubridate stacks up.
Currently
leap_year()is pure R and is relatively speaking quite slow. With the lubridate main branch:Created on 2025-05-01 with reprex v2.1.1
This PR moves the leap year calculation to C, simply wrapping the
IS_LEAPmacro already used elsewhere in the codebase. With it I see a roughly 30-fold performance increase on my machine:Created on 2025-05-01 with reprex v2.1.1