More generic functions - #1101
Open
mgirlich wants to merge 13 commits into
Open
Conversation
added 10 commits
March 3, 2021 10:04
hadley
reviewed
Mar 3, 2021
hadley
left a comment
hadley
left a comment
Member
There was a problem hiding this comment.
Looks good — one comment about the position of ... and then can you please add a bullet to NEWS?
| #' @export | ||
| #' @rdname chop | ||
| unchop <- function(data, cols, keep_empty = FALSE, ptype = NULL) { | ||
| unchop <- function(data, cols, keep_empty = FALSE, ptype = NULL, ...) { |
Member
There was a problem hiding this comment.
In general, I think it's better to put the dots before the first optional argument. It's possible that a few people might have relied on partial or position based matching, but check_dots_used() will catch that.
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
In build_wider_spec() I put the dots after names_from and values_from as they felt like main arguments and that's also how they were used in the test names_glue affects output names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1071 .
With the recent effort of bringing tidyr verbs to
dtplyrI guess it makes sense to make these functions generic now.