Skip to content

Make pack() and unpack() generic - #1372

Open
krlmlr wants to merge 1 commit into
mainfrom
f-generic-pack-unpack
Open

Make pack() and unpack() generic#1372
krlmlr wants to merge 1 commit into
mainfrom
f-generic-pack-unpack

Conversation

@krlmlr

@krlmlr krlmlr commented Jun 10, 2022

Copy link
Copy Markdown
Member

Useful now that duckdb supports them with the DBI interface: duckdb/duckdb#3495.

@krlmlr
krlmlr requested a review from DavisVaughan June 12, 2022 04:28
@krlmlr

krlmlr commented Jun 12, 2022

Copy link
Copy Markdown
Member Author

I wonder if we should instead define new generics build_pack_spec() and pack_spec(), similarly for "unpack". The DuckDB implementation is copying a bit of code from tidyr: duckdb/duckdb#3829.

@olivroy

olivroy commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

I may be mistaken, but I think this would help separate_wider_delim() / separate_wider_regex() work with sf objects. Is there a plan to merge this PR? (r-spatial/sf#2359)

@elipousson

Copy link
Copy Markdown

Adding to @olivroy's comment, it would be great to see this PR reviewed and merged to support the implementation of separate_wider_delim() / separate_wider_regex() with sf.

I'm teaching sf to a graduate course this fall and seeing these functions silent dropping the sf class (when 90+% of tidyverse functions work seamlessly) is such a weird and potentially frustrating loophole!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants