Make pack() and unpack() generic - #1372
Open
krlmlr wants to merge 1 commit into
Open
Conversation
Member
Author
|
I wonder if we should instead define new generics |
Contributor
|
I may be mistaken, but I think this would help |
|
Adding to @olivroy's comment, it would be great to see this PR reviewed and merged to support the implementation of I'm teaching sf to a graduate course this fall and seeing these functions silent dropping the sf class (when 90+% of tidyverse functions work seamlessly) is such a weird and potentially frustrating loophole! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful now that duckdb supports them with the DBI interface: duckdb/duckdb#3495.