tests: add edge-case tests for hoist() with .remove = FALSE - #1644
Closed
LeonidasZhak wants to merge 1 commit into
Closed
tests: add edge-case tests for hoist() with .remove = FALSE#1644LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
Add 5 test blocks covering hoist() behavior when .remove = FALSE: 1. Preserves original list-column when extracting named elements 2. Preserves list-column even when all elements are extracted 3. Works with empty data frames (0 rows) 4. Preserves grouped data frame class 5. Handles multiple pluckers simultaneously These scenarios had no test coverage despite .remove being a documented parameter. The default .remove = TRUE was already well tested.
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 5 test blocks (83 lines) for
hoist()behavior when.remove = FALSE, covering scenarios that had no test coverage.Motivation
The
.removeparameter defaults toTRUEand that path is well tested. But.remove = FALSE— which preserves the original list-column after extraction — had zero dedicated tests. This is a documented parameter used in data cleaning pipelines where you want to peek into list-columns without dismantling them.Tests Added
.remove = FALSEValidation
All 61 existing tests pass. 2 new tests added (5 test blocks, 83 lines, 1 file changed).