feat: Add direct Highway SIMD integration for whitespace trimming #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate Google Highway library directly into vroom for portable SIMD operations. This approach uses Highway's dynamic dispatch mechanism to select optimal implementations at runtime based on CPU capabilities (AVX2, AVX-512, SSE4, NEON, etc.). Key changes: - Add Highway library under src/hwy/ for portable SIMD primitives - Create simd_dispatch.cc/.h with SIMD-optimized whitespace trimming - Add r_abort.cc for R-compatible Highway error handling - Update Makevars to compile Highway and SIMD dispatch module The SIMD whitespace trimming functions process data in SIMD-width chunks, providing significant speedup for fields with leading/trailing whitespace. This addresses the alternative approach mentioned in issue #6: using Highway directly for SIMD operations without the full libvroom library. Closes #6 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Collaborator
Author
|
Closing - PR should be opened against jimhester/vroom instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the alternative approach described in #6: integrating Google Highway directly for SIMD operations instead of using the full libvroom library.
The Highway library provides portable SIMD/vector intrinsics with runtime dispatch based on CPU capabilities (AVX2, AVX-512, SSE4, NEON, etc.). The SIMD whitespace trimming functions process data in SIMD-width chunks, which can significantly speed up trimming operations on fields with leading/trailing whitespace.
Test plan
Closes #6