refactor: extract header stamp extraction into separate library#87
Merged
refactor: extract header stamp extraction into separate library#87
Conversation
Move kTypesWithHeader, extract_header_stamp, and the deserialization logic into header_stamp.hpp/cpp. This consolidates 18 repetitive deserialize-and-return blocks into a single template helper, making it easier to add new message types. Also removes unused created_topics variable and adds missing <cctype> include for std::toupper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kTypesWithHeader,extract_header_stamp(), and deserialization logic frombag_converter.hpp/cppinto newheader_stamp.hpp/cppdeserialize_header_stamp<MsgT>()template helpercreated_topicsvariable fromrun_impl()#include <cctype>forstd::toupperusageTest plan
colcon build--use-header-stamp-as-log-timeto confirm header stamp extraction still works