Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Laravel 10 #677

Closed

Conversation

jasonmccreary
Copy link

@jasonmccreary jasonmccreary commented Feb 3, 2023

This supersedes #676 by ensuring both Laravel 9 and Laravel 10 are supported.

In addition, it sets the minimum requirement for Symfony dependencies to ^6.0 as that was the minimum required by Laravel 9.

@jasonmccreary
Copy link
Author

The failing build for PHP 8.3 is because of the bump in mnapoli/front-yaml to be compatible with Symfony 6. One of its underlying dependencies has a <8.3 PHP requirement.

Since 8.3 is not officially released yet, I am not going to worry about this as it should resolve itself in time. However, you may want to remove PHP 8.3 from the matrix build until then.

@jasonmccreary
Copy link
Author

The failing "Format" job is due to a restriction of the Git remote. It's currently origin. However, since I am an outside contributor, my branch is on a different remote. This job should be updated to properly pull from other remotes, or skipped when the branch does not exist on origin.

@bakerkretzmar
Copy link
Collaborator

I'm not sure we can upgrade mnapoli/front-yaml without tagging a new major version. Is that directly related to supporting Laravel 10 or could we just add that and only touch other dependencies we absolutely have to?

@owenvoke
Copy link
Contributor

I think Front YAML has to be updated as v1 doesn't support Symfony 6 ☹️

@damiani
Copy link
Contributor

damiani commented Mar 26, 2024

Superseded by #702

@damiani damiani closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants