Adds pull command #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcavanunez
force-pushed
the
gc/pull-recipe
branch
from
6565591 to
15bb280
Compare
mattstauffer
requested changes
Apr 16, 2025
| if (empty($selectedRemoteRecipes)) { | ||
| return multiselect( | ||
| label: 'Which recipe(s) should I pull?', | ||
| options: app(MiseService::class)->allForSelect(), |
There was a problem hiding this comment.
OK, so there are a few things I have questions about.
How do we handle:
- Recipes that we already have locally and haven't changed
- Recipes that we already have locally and have changed
- Recipes that we have a local one with the same name but it's not the same
|
|
||
| private function install($key) | ||
| { | ||
| info('Installing recipe: ' . $key); |
There was a problem hiding this comment.
I'm never totally sure about best practices here, but is there any value in us shipping a hash of the file contents? I know people do that, but I'm trying to figure out if there's any way that helps us in this context.
gcavanunez
force-pushed
the
gc/pull-recipe
branch
from
883c268 to
21d69f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way to pull commands from an api and creates them under the a user's local recipes dir
Demo
mise-demo-speedrun.mp4
Notes
We may want to hold off on this guy until we get the saas app uup and running.