Monthly Resource Digest #594
Conversation
|
|
||
| auth()->user()->save(); | ||
| if ($user) { |
There was a problem hiding this comment.
Can the user.preferences.update route be moved up into the auth middleware group? If so that would avoid the need for this if condition.
| 'is_subscriber' => 'nullable|boolean', | ||
| ]); | ||
|
|
||
| $user->is_subscriber = $request->has('digest-subscriber'); |
There was a problem hiding this comment.
I think track_id and digest-subscriber can be added to the validate check before updating.
|
|
||
| $user->is_subscriber = false; | ||
| $user->unsubscribe_token = null; | ||
| $user->save(); |
There was a problem hiding this comment.
I'd do this in a single $user->update() call.
app/Mail/ResourceDigestEmail.php
Outdated
| $this->resources = $resources; | ||
| $this->user = $user; | ||
| $this->unsubscribeUrl = $unsubscribeUrl; | ||
| } |
There was a problem hiding this comment.
This can be rewritten like the following and then the properties on lines 16-18 can be removed.
| } | |
| public function __construct( | |
| public $resources, | |
| public $user, | |
| public $unsubscribeUrl | |
| ) {} |
Co-authored-by: Andrew Morgan <[email protected]>
| $user->is_subscriber = false; | ||
| $user->unsubscribe_token = null; | ||
| $user->save(); |
There was a problem hiding this comment.
| $user->is_subscriber = false; | |
| $user->unsubscribe_token = null; | |
| $user->save(); | |
| $user->update([ | |
| 'is_subscriber' => false, | |
| 'unsubscribe_token' => null, | |
| ]); |
When I can, I prefer using update because it feels more concise (despite being one more line) and tidy.
| public function up(): void | ||
| { | ||
| Schema::table('users', function (Blueprint $table) { | ||
| $table->boolean('is_subscriber')->default(false); |
There was a problem hiding this comment.
I like to add ->after() and specify a column that I want the new column to appear after so the timestamps (created_at, etc.) are always last.
This option is only available in MySQL and MariaDB, so we couldn't use it for a Postgres project.
This PR gives users the ability to opt-in to a monthly digest that lists resources added within the last 30 days. If no resources have been added, an email is not sent.
I'll be adding a New Resource page, accessible from the auth menu, in a follow-up PR.