Allow a model to be both a parent and child#104
Allow a model to be both a parent and child#104chadhutchins wants to merge 2 commits intotighten:mainfrom
Conversation
…work previously was due to duplicate method names in HasParent and HasChildren traits.
…et the correct Parent Class name. If this does not happen, the wrong foreign keys are provided when pulling related data.
|
@driftingly Is there something to be done before this can be merged? I'd be interested in this functionality, so I'd be glad to help. |
|
@tobias-grasse If you're able to, tests would be helpful. |
|
I ran this update through the test suite of a larger project and didn't run into any issues. |
| static $parentClassName; | ||
|
|
||
| return $parentClassName ?: $parentClassName = (new ReflectionClass($this))->getParentClass()->getName(); | ||
| if ($parentClassName) return $parentClassName; | ||
|
|
||
| $parentClassName = (new ReflectionClass($this))->getParentClass()->getName(); | ||
|
|
||
| $parent = new $parentClassName; | ||
| return $parent->hasParent === true ? $parent->getParentClass() : $parentClassName; |
There was a problem hiding this comment.
This may not work as expected.
Initially $parentClassName was set as static to cache the value. If $parentClassName had a value, it was returned; otherwise, a value was generated, assigned, then returned. The next time getParentClass() was called, the cached value was returned.
The updated code returns $parentClassName if a value exists.
If a value does not exist, one is generated and assigned.
Then we new up the parent class, and check if the parent class has a parent, if it does we call getParentClass() and return the result. The next time this method is called we will return the cached $parentClassName and not the result of $parent->getParentClass().
Does that make sense?
|
@tobias-grasse @driftingly this need is coming back up for me... either of yall interested in help me get this to the finish line? thanks! |
|
@chadhutchins I haven't familiarized myself with the problem again, but I wonder if there's a way we can add another static variable to account for the two cases. Like adding a static version of We can also use reflection to see if the parent class has the |
3 participants
The only reason this didn't work previously was due to duplicate method names in HasParent and HasChildren traits.
We have a use case where we have several layers of abstraction:
A extends B
B extends C
With this change we can now:
A HasParent
B HasParent, Has Children
C Has Children
and by C::find('1234') will return the class instance of A correctly.