Fix MailableMethodsInBuild destroying constructor formatting#378
Merged
driftingly merged 1 commit intotighten:mainfrom Feb 27, 2026
Conversation
The formatter was creating new ClassMethod nodes unconditionally, which breaks PhpParser's printFormatPreserving identity check and causes the entire constructor to be re-printed from scratch — collapsing multi-line promoted properties into a single line. Mutate $node->stmts in-place instead, and return null early when there are no statements to move.
Member
|
Thanks @superbiche 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MailableMethodsInBuildformatter collapsing multi-line constructor parameters (e.g. promoted properties) into a single lineconstructorVisitorandbuildVisitornow mutate$node->stmtsin-place instead of creating newClassMethodnodes, preserving PhpParser'sprintFormatPreservingidentity checknullwhen no statements need moving, so untouched constructors aren't re-printed at allExample
Given a Mailable with multi-line promoted constructor properties:
Before (broken) — the formatter collapses everything to one line:
After (fixed) — constructor formatting is preserved as-is.
Test plan
does_not_alter_constructor_parameter_formatting— verifies a Mailable with multi-line promoted constructor properties is not reformatted