fix indexes for cached objects #20
dimadimxphpinsight.yml
on: pull_request
PHP Insights checks
18s
Annotations
10 errors and 1 warning
|
PHP Insights checks:
lib/Skeleton/Object/Config.php#L19
* [Forbidden public property] Do not use public properties. Use method access instead.
* [Property type hint] Property \Skeleton\Object\Config::$cache_handler does not have native type hint for its value but it should be possible to add it based on @var annotation "string".
|
|
PHP Insights checks:
lib/Skeleton/Object/Config.php#L27
* [Forbidden public property] Do not use public properties. Use method access instead.
* [Property type hint] Property \Skeleton\Object\Config::$cache_handler_config does not have native type hint for its value but it should be possible to add it based on @var annotation "string".
|
|
PHP Insights checks:
lib/Skeleton/Object/Config.php#L1
* [Declare strict types] Missing declare(strict_types=1).
* [Braces] @@ -2,21 +2,20 @@
/**
* Config class
* Configuration for Skeleton\Object
*
* @author David Vandemaele <[email protected]>
*/
namespace Skeleton\Object;
class Config {
-
/**
* Caching backend handler
*
* @access public
* @var string $classname
*/
public static $cache_handler = false;
/**
* Caching backend config
@@ -18,12 +17,11 @@
*/
public static $cache_handler = false;
/**
* Caching backend config
*
* @access public
* @var string $classname
*/
public static $cache_handler_config = [];
-
}
* [No blank lines after class opening] @@ -2,21 +2,20 @@
/**
* Config class
* Configuration for Skeleton\Object
*
* @author David Vandemaele <[email protected]>
*/
namespace Skeleton\Object;
class Config {
-
/**
* Caching backend handler
*
* @access public
* @var string $classname
*/
public static $cache_handler = false;
/**
* Caching backend config
|
|
PHP Insights checks:
lib/Skeleton/Object/Model.php#L19
* [Forbidden public property] Do not use public properties. Use method access instead.
* [Property type hint] Property \Skeleton\Object\Model::$id does not have native type hint for its value but it should be possible to add it based on @var annotation "int".
|
|
PHP Insights checks:
lib/Skeleton/Object/Model.php#L219
* [Unused variable] Unused variable $language.
* [Short list] list(...) is forbidden, use [...] instead.
|
|
PHP Insights checks:
lib/Skeleton/Object/Model.php#L324
* [Unused variable] Unused variable $language.
* [Function call argument spacing] Expected 1 space after comma in argument list; 2 found
* [Short list] list(...) is forbidden, use [...] instead.
|
|
PHP Insights checks:
lib/Skeleton/Object/Model.php#L97
* [Disallow equal operators] Operator == is disallowed, use === instead.
|
|
PHP Insights checks:
lib/Skeleton/Object/Model.php#L182
* [Disallow equal operators] Operator != is disallowed, use !== instead.
|
|
PHP Insights checks:
lib/Skeleton/Object/Model.php#L192
* [Disallow equal operators] Operator != is disallowed, use !== instead.
|
|
PHP Insights checks:
lib/Skeleton/Object/Model.php#L229
* [Disallow equal operators] Operator != is disallowed, use !== instead.
|
|
PHP Insights checks
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|