Skip to content

dell-latitude-7330: Change default network controller#1103

Merged
brianmcgillion merged 2 commits intotiiuae:mainfrom
vunnyso:vs-dellDefaultNet
Mar 25, 2025
Merged

dell-latitude-7330: Change default network controller#1103
brianmcgillion merged 2 commits intotiiuae:mainfrom
vunnyso:vs-dellDefaultNet

Conversation

@vunnyso
Copy link
Collaborator

@vunnyso vunnyso commented Mar 25, 2025

Description of changes

  1. Since we have more laptops with network controller which may enumerate on 0000:72:00.0 PCI bus so
    making that as default profile for dell-latitude-7330.
  2. Add Dell Latitude target in PR template.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    • AGX
    • NX
    • x86_64
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?
    * Keep the frequently used target as specified in the default Dell 7330 profile.

@vunnyso vunnyso temporarily deployed to internal-build-workflow March 25, 2025 09:37 — with GitHub Actions Inactive
@vunnyso vunnyso temporarily deployed to internal-build-workflow March 25, 2025 09:38 — with GitHub Actions Inactive
vunnyso added 2 commits March 25, 2025 11:45
Since we have more laptops with network controller
which may enumerate on "0000:72:00.0" PCI bus so
making that as default profile for dell-latitude-7330.

Signed-off-by: Vunny Sodhi <vunny.sodhi@unikie.com>
Signed-off-by: Vunny Sodhi <vunny.sodhi@unikie.com>
@vunnyso vunnyso force-pushed the vs-dellDefaultNet branch from 0be4145 to 1d8df4d Compare March 25, 2025 09:48
@vunnyso vunnyso temporarily deployed to internal-build-workflow March 25, 2025 09:48 — with GitHub Actions Inactive
@vunnyso vunnyso temporarily deployed to internal-build-workflow March 25, 2025 09:48 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion merged commit 413bae9 into tiiuae:main Mar 25, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants