Skip to content

feat(graphics): add idle management configuration option#1110

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:idle-handling-option
Mar 28, 2025
Merged

feat(graphics): add idle management configuration option#1110
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:idle-handling-option

Conversation

@kajusnau
Copy link
Collaborator

Description of changes

  1. Add Idle Management Config Option to options.ghaf.profiles.graphics:
    • Defaults to true to enable swayidle idle management

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
    • Tested on Dell Latitude x86_64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • [-] Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    • AGX
    • NX
    • x86_64
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?
    • Allows choosing whether to enable or disable idle management for particular targets

@kajusnau kajusnau temporarily deployed to internal-build-workflow March 28, 2025 09:03 — with GitHub Actions Inactive
@kajusnau kajusnau temporarily deployed to internal-build-workflow March 28, 2025 09:04 — with GitHub Actions Inactive
@kajusnau kajusnau force-pushed the idle-handling-option branch from 3e48d9b to 17bc411 Compare March 28, 2025 09:12
@kajusnau kajusnau temporarily deployed to internal-build-workflow March 28, 2025 09:12 — with GitHub Actions Inactive
@kajusnau kajusnau marked this pull request as ready for review March 28, 2025 09:13
@kajusnau kajusnau requested a review from brianmcgillion March 28, 2025 09:13
@kajusnau kajusnau self-assigned this Mar 28, 2025
@kajusnau kajusnau temporarily deployed to internal-build-workflow March 28, 2025 09:13 — with GitHub Actions Inactive
@kajusnau kajusnau force-pushed the idle-handling-option branch from 17bc411 to ae3185f Compare March 28, 2025 09:15
@kajusnau kajusnau temporarily deployed to internal-build-workflow March 28, 2025 09:15 — with GitHub Actions Inactive
@kajusnau kajusnau temporarily deployed to internal-build-workflow March 28, 2025 09:15 — with GitHub Actions Inactive
- Add idleManagement option to graphics profile
- Default to true for enabling swayidle functionality in labwc

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@kajusnau kajusnau force-pushed the idle-handling-option branch from ae3185f to 1365bf9 Compare March 28, 2025 09:46
@kajusnau kajusnau temporarily deployed to internal-build-workflow March 28, 2025 09:46 — with GitHub Actions Inactive
@kajusnau kajusnau temporarily deployed to internal-build-workflow March 28, 2025 09:46 — with GitHub Actions Inactive
@kajusnau
Copy link
Collaborator Author

Edit:

  • Removed conflicting graphics.labwc.autolock.enable assignment from orin target
  • Removed redundant graphics.labwc.autolock.enable assignments from user trial profiles

@kajusnau kajusnau requested a review from vunnyso March 28, 2025 09:50
@brianmcgillion brianmcgillion merged commit 1e6d6ed into tiiuae:main Mar 28, 2025
25 checks passed
@kajusnau kajusnau deleted the idle-handling-option branch May 21, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants