Skip to content

chore: update pull request template#1127

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:pr-template-update
Apr 4, 2025
Merged

chore: update pull request template#1127
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:pr-template-update

Conversation

@kajusnau
Copy link
Collaborator

@kajusnau kajusnau commented Apr 4, 2025

Description of changes

Update GitHub PR template
Open for discussion and improvements

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
    • Tested on Dell Latitude x86_64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    • AGX
    • NX
    • x86_64
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

@kajusnau kajusnau temporarily deployed to internal-build-workflow April 4, 2025 08:59 — with GitHub Actions Inactive
@kajusnau kajusnau temporarily deployed to internal-build-workflow April 4, 2025 09:00 — with GitHub Actions Inactive
@kajusnau kajusnau self-assigned this Apr 4, 2025
@kajusnau kajusnau force-pushed the pr-template-update branch from 27e1019 to 2cec9aa Compare April 4, 2025 09:04
@kajusnau kajusnau temporarily deployed to internal-build-workflow April 4, 2025 09:04 — with GitHub Actions Inactive
@kajusnau kajusnau temporarily deployed to internal-build-workflow April 4, 2025 09:04 — with GitHub Actions Inactive
@kajusnau kajusnau force-pushed the pr-template-update branch from 2cec9aa to 7fa3fc5 Compare April 4, 2025 09:34
@kajusnau kajusnau temporarily deployed to internal-build-workflow April 4, 2025 09:34 — with GitHub Actions Inactive
@kajusnau kajusnau temporarily deployed to internal-build-workflow April 4, 2025 09:34 — with GitHub Actions Inactive
@kajusnau kajusnau force-pushed the pr-template-update branch from 7fa3fc5 to 47ba6c7 Compare April 4, 2025 09:35
@kajusnau kajusnau temporarily deployed to internal-build-workflow April 4, 2025 09:35 — with GitHub Actions Inactive
@kajusnau kajusnau temporarily deployed to internal-build-workflow April 4, 2025 09:35 — with GitHub Actions Inactive
Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@kajusnau kajusnau force-pushed the pr-template-update branch from 47ba6c7 to bc7537f Compare April 4, 2025 09:40
@kajusnau kajusnau temporarily deployed to internal-build-workflow April 4, 2025 09:40 — with GitHub Actions Inactive
@kajusnau kajusnau temporarily deployed to internal-build-workflow April 4, 2025 09:40 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion merged commit 8f8bf1c into tiiuae:main Apr 4, 2025
24 of 25 checks passed
@kajusnau kajusnau deleted the pr-template-update branch May 21, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants