Skip to content

Comments

bump: standard bump#1158

Merged
brianmcgillion merged 3 commits intotiiuae:mainfrom
brianmcgillion:sun-bump
May 19, 2025
Merged

bump: standard bump#1158
brianmcgillion merged 3 commits intotiiuae:mainfrom
brianmcgillion:sun-bump

Conversation

@brianmcgillion
Copy link
Collaborator

@brianmcgillion brianmcgillion commented Apr 20, 2025

Description of Changes

Quite a lot of churn in nixpkgs so a full retest is needed.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. ...

@kajusnau
Copy link
Collaborator

Adding note here that Cosmic DE will also likely be bumped with this PR
https://nixpk.gs/pr-tracker.html?pr=401497

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
NixOS/nixpkgs#395275

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@leivos-unikie leivos-unikie added Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin labels May 19, 2025
@milva-unikie
Copy link

milva-unikie commented May 19, 2025

Tested on

  • lenovo-x1-gen11-cosmic-debug (new image)
  • lenovo-x1-carbon-gen11-debug (nixos-rebuild switch)

Issues

  • The Sticky Notes app does not open on Labwc
[milla@gui-vm:~]$ ghaf-open 'Sticky Notes'
/run/current-system/sw/bin/ghaf-open: line 34: 12898 Segmentation fault      (core dumped) /nix/store/lax2gd4k5b05vm64hvcgza5k8q7d9mw3-sticky-notes-0.2.6/bin/com.vixalien.sticky
  • On Cosmic, Sticky Notes has already been disabled because it did not work properly.
  • Cosmic does not build. Patch in overlays/custom-packages/cosmic/cosmic-comp/default.nix needs to be disabled to get it to build.

Working

  • Other than that everything seems to be good on both Labwc and Cosmic.
  • Test-automation passes on both.

Notes

  • While testing this PR I noticed that webcam and Chromecast are not working in Chrome as expected. The issue also exists in mainline, I will create bugs for them.

@milva-unikie milva-unikie added the bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR label May 19, 2025
@leivos-unikie
Copy link
Contributor

UI, performance and automated tests were fine on Orin AGX. Checked with cross-compiled flash and native USB SSD image.

@brianmcgillion
Copy link
Collaborator Author

@milva-unikie seems that the issue is upstream for sticky-notes. NixOS/nixpkgs#408670 I created this PR to nixpkgs, will take some time to get reviewed and merged. so we have 2 options: disable sticky-notes and reenable it at the next bump. 2, leave it enabled and it will hopefully get fixed on the next bump. Easiest I think is to leave it enabled, then we do not need to remember to re-enable it. but the choice is yours.

@leivos-unikie leivos-unikie added Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin Tested on Orin NX Cross This PR has been tested on NVIDIA Jetson NX Orin cross-compiled labels May 19, 2025
@leivos-unikie
Copy link
Contributor

Tested cross-compiled and native image on Orin NX. No regressions found.

@milva-unikie
Copy link

@milva-unikie seems that the issue is upstream for sticky-notes. NixOS/nixpkgs#408670 I created this PR to nixpkgs, will take some time to get reviewed and merged. so we have 2 options: disable sticky-notes and reenable it at the next bump. 2, leave it enabled and it will hopefully get fixed on the next bump. Easiest I think is to leave it enabled, then we do not need to remember to re-enable it. but the choice is yours.

I agree, no need to disable the Sticky Notes. I will add a skip to our test-automation for that case so that it won't fail in all pipelines.

Temp disable the security context patch as it needs to be rebased onto
the new cosmic alpha 7.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@milva-unikie
Copy link

lenovo-x1-gen11-cosmic-debug build works now.

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR labels May 19, 2025
@brianmcgillion brianmcgillion merged commit 3ed9e9f into tiiuae:main May 19, 2025
25 of 26 checks passed
@brianmcgillion brianmcgillion deleted the sun-bump branch May 19, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on Orin AGX Cross This PR has been tested on NVIDIA Jetson AGX Orin cross-compiled Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin Tested on Orin NX Cross This PR has been tested on NVIDIA Jetson NX Orin cross-compiled Tested on Orin NX This PR has been tested on NVIDIA Jetson NX Orin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants