Skip to content

Comments

bump:wireguard reactivating buttons and improvements#1192

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
enesoztrk:bump/wireguard-gui
May 9, 2025
Merged

bump:wireguard reactivating buttons and improvements#1192
brianmcgillion merged 1 commit intotiiuae:mainfrom
enesoztrk:bump/wireguard-gui

Conversation

@enesoztrk
Copy link
Contributor

@enesoztrk enesoztrk commented May 7, 2025

Description of Changes

  • Save conf files to WireGuard config path
  • Remove button is fixed
  • Export config files functionality implementation
  • Better error handling
  • appuser can only access the conf files
  • Fix public key handling
  • CLI args for config files' dir and ownership

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Generate the base configuration by clicking the Generate Configs button.
  2. Edit parameters (PublicKey, AllowedIps, Address,etc.) to pass same test procedure
  3. Export the configuration by clicking the Export button.
  4. Note that the configuration file can only be exported to under /home directory. (for example: /home/ghaf/)
  5. Verify the ownership status of the exported configuration file; it should match the owner of the parent folder.
  6. Attempt to remove the configuration by clicking the Remove button. A confirmation dialog should appear to request your confirmation.
  7. Import the configuration using the Import Tunnel button.
  8. You may repeat the procedures outlined in step 2.

@enesoztrk enesoztrk force-pushed the bump/wireguard-gui branch from df51797 to c728457 Compare May 8, 2025 08:35
@enesoztrk enesoztrk marked this pull request as ready for review May 8, 2025 08:36
@enesoztrk enesoztrk added the Needs Testing CI Team to pre-verify label May 8, 2025
@enesoztrk enesoztrk requested a review from brianmcgillion May 8, 2025 08:37
@milva-unikie
Copy link

Tested on Lenovo-X1 (new image)

All good!

  • Connection can be made using Wireguard
  • Configs can be exported, removed and then imported again
  • Test-automation passes

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels May 9, 2025
* Save conf files to WireGuard config path
* Remove button is fixed
* Export config files functionality implementation
* Better error handling
* appuser can only access the conf files
* Fix public key handling
* CLI args for config files' dir and ownership

Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
@brianmcgillion brianmcgillion merged commit 7350671 into tiiuae:main May 9, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants