Skip to content

Comments

fix: add configurable password for mitmweb UI#1197

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
enesoztrk:hotfix/mitmproxyweb-ui
May 13, 2025
Merged

fix: add configurable password for mitmweb UI#1197
brianmcgillion merged 1 commit intotiiuae:mainfrom
enesoztrk:hotfix/mitmproxyweb-ui

Conversation

@enesoztrk
Copy link
Contributor

@enesoztrk enesoztrk commented May 12, 2025

Description of Changes

MitmWebUI was updated by the mitmproxy team, introducing a password requirement for login that was previously unnecessary.
mitmproxy/mitmproxy#7551

  • web_password parameter has been passed through webUIPswd mitmproxy module option.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

SSRCSP-6559

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Click MitmWebUI icon
  2. Logs should appear when the network traffic is active

Signed-off-by: Enes Öztürk <enes.ozturk@unikie.com>
@enesoztrk enesoztrk marked this pull request as ready for review May 12, 2025 14:53
Copy link
Collaborator

@brianmcgillion brianmcgillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@humaidq-tii humaidq-tii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will note that this password is readable world-wide, it maybe should be noted. Also this shouldn't be used in production.

@brianmcgillion brianmcgillion merged commit 5b1df15 into tiiuae:main May 13, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants