Skip to content

fix(pci-ports): start PCIe port range from 1#1664

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
vunnyso:vs-KSAudioFix
Dec 31, 2025
Merged

fix(pci-ports): start PCIe port range from 1#1664
brianmcgillion merged 1 commit intotiiuae:mainfrom
vunnyso:vs-KSAudioFix

Conversation

@vunnyso
Copy link
Collaborator

@vunnyso vunnyso commented Dec 30, 2025

Description of Changes

This patch addresses the issue where PCIe root port IDs start from pci_hotplug_0, while VFIO devices are attached starting from pci_hotplug_1. This discrepancy causes a mismatch between the root port numbering and the device bus assignment.

Fixes: https://jira.tii.ae/browse/SSRCSP-7727

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Please refer to Description of Changes section.

This patch addresses the issue where PCIe root
port IDs start from pci_hotplug_0, while VFIO
devices are attached starting from pci_hotplug_1.
This discrepancy causes a mismatch between the root port
numbering and the device bus assignment.

Signed-off-by: Vunny Sodhi <vunny.sodhi@unikie.com>
@vunnyso
Copy link
Collaborator Author

vunnyso commented Dec 30, 2025

Latest pre-merge failure seen in https://ci-prod.vedenemo.dev/job/ghaf-pre-merge/1163/pipeline-overview/log?nodeId=455 is related with System76 serial test case and not related with PR changes. CI team working on fix.

@azbeleva
Copy link

There was issue from the test side, now it is fixed, and tests' rerun was successful.

@vunnyso
Copy link
Collaborator Author

vunnyso commented Dec 30, 2025

There was issue from the test side, now it is fixed, and tests' rerun was successful.

Thanks @azbeleva for the quick fix 🙂

@brianmcgillion brianmcgillion merged commit 5c2e6f4 into tiiuae:main Dec 31, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants