systemd: Add overlay for systemd to change token prompts type#1695
systemd: Add overlay for systemd to change token prompts type#1695brianmcgillion merged 1 commit intotiiuae:mainfrom
Conversation
|
Our remote builder is struggling to build the laptop targets with this, they all failed after trying to build for a couple of hours yesterday. I will try to trigger the laptop builds one at a time to hopefully get them to complete the build. |
|
I built lenovo-x1 image locally and booted from USB SSD. Yubikey functionality seems to work now, except if booting without Yubikey (after local user with Yubikey has been created). Then it does not provide any opportunity to log in with password only. If Yubikey is unplugged when logged in then it locks the screen and does accept password at Lock screen. If user is then logged out while Yubikey not connected, logging in with password is not possible. If device is booted to login screen without Yubikey log in does not work via Yubikey after plugging it in. |
|
The build was stuck for hours with low load and low CPU usage in the remote builder. So it's not about a massive rebuild. I fed remote builder ps aux listing to Copilot:
A bit more detailed investigation
|
I managed to make this build by manually triggering the build one-by-one for some derivations that got stuck when building the full closure. Following analysis was done using output The problem is, this changes
Full list of packages that need to be rebuild due to the change in this PR can be queried with nix-store (once evaluated): That is, 2044 derivations need to be rebuild, including some big ones too e.g. chromium and element. |
9124aa7 to
c153ebe
Compare
|
Thanks @ktusawrk and @henrirosten for your analysis. |
Whenever possible, I think we should prefer having patches such as this merged upstream first and take them to ghaf |
Reason for it as
In lock screen, session is active so it accept password.
Looks like Conclusion: Open to suggestions and thoughts! |
c153ebe to
2204d53
Compare
|
I'm afraid waiting for the systemd release is not viable. Maybe this PR needs to get merged and we have to deal with it in the release build environment in some unorthodox way, like making the build in smaller chunks. |
|
I checked that login with password without Yubikey is failing also with an image built from 5c2e6f4, before Active Directory. There has been some discussion if login without Yubikey is even required. Probably it makes ghaf more secure if login is allowed only with Yubikey (when user is created with Yubikey). So am ok with the feature. There is just change compared to that how Yubikey used to work with ghaf previously. I checked that in manual tests we have run such Yubikey test (last time in release 25.11.1 testing) where login with password succeeds after booting without Yubikey. |
|
tests on lenovo-x1
|
Use PAM_TEXT_INFO for security token prompts in systemd-homed. The prompts for security token interaction were previously sent as error messages. This commit changes them to informational messages. Additionally, the unused patch for a soft-lock in cosmic-greeter has been removed. Signed-off-by: Vunny Sodhi <vunny.sodhi@unikie.com>
2204d53 to
9325ff4
Compare
|
All checks have passed. |
Description of Changes
Use PAM_TEXT_INFO for security token prompts in systemd-homed.
The prompts for security token interaction were previously sent as error messages. This commit changes them to informational messages.
Additionally, the unused patch for a soft-lock in cosmic-greeter has been removed.
Upstream patch link: systemd/systemd#40412 (Merged)
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify: