feat(about): add about-ghaf application#1697
Conversation
|
Nice, but should we consider having the source for the page itself in |
Yes we could. My thinking was that this writeup applies specifically to our reference laptop implementation, hence the location. Can move the package itself somewhere else though |
|
moved website to packages |
|
Tested on Darter Pro
|
Add a local "Getting Started" application to the laptop. It is a local website that entails information about the laptop and its features. Signed-off-by: Manuel Bluhm <manuel@ssrc.tii.ae>
|
update: brighter font and start maximized |
There was a problem hiding this comment.
Really nice looking page! Easy to navigate, clear wording, good tutorials.
Some objective, some subjective notes in my review comments, as well as some general thoughts here:
- I think the use of colors is a bit excessive in general. In some cases it makes some text more difficult to read (light text against a light-colored background), in other cases it clashes with pre-existing color definitions, as I mention in the comments.
- Depending on the target audience, it could be argued that the language should be more formal:
can’t -> cannot won’t -> will not don’t -> do not doesn’t -> does not didn’t -> did not isn’t -> is not etc
Late edit:
I tested 7db1c4a, so maybe not everything applies.
| to persist across reboots. | ||
| </p> | ||
|
|
||
| <h3>Ghaf's Multi-Layer Defense</h3> |
There was a problem hiding this comment.
For this section I have a couple notes:
- Using (arbitrary?) colors here IMO doesn't add anything to the overall presentation, and can even clash with some of our existing color schemes. e.g. The Green used for "layer 1" is almost identical to the business VM green, red in "Result" is almost the same as chrome VM red
- If these are actual layers would it help to represent them as such? As a sort of stack
- The result is not a layer, so it would help if it was a visually distinct element
| </p> | ||
| </div> | ||
|
|
||
| <h3>Hardware Kill-Switches</h3> |
There was a problem hiding this comment.
As mentioned before, this section again contains some of the same colors used elsewhere.
Do we need the colors here? Maybe icons, as used in the killswitch app itself, would be more beneficial? Not sure if that complicates things too much for this pure html.
| </p> | ||
|
|
||
| <div class="restrictions-box"> | ||
| <h4>Applications Cannot</h4> |
There was a problem hiding this comment.
Would the design be more uniform here if the style of this box was the same as that of "The Security Challenge" and "Emergency Privacy Mode"?
| font-weight="600" | ||
| letter-spacing="0.1em" | ||
| > | ||
| SYSTEM VMs — HARDWARE GATEKEEPERS |
There was a problem hiding this comment.
Again a similar situation as before with the use of colors.
E.g. now audio VM is using the same (or similar) color as business VM did before
kajusnau
left a comment
There was a problem hiding this comment.
Approving so as not to block the PR in case we need to move forward quickly.
|
In the section "What this means for you" --> "Colored Borders" for the VPN part Section Testing Kill switch |
Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
92596d8 to
6b643d6
Compare
Description of Changes
Add a local "Getting Started" application to the laptop. It is a local website that entails information about the laptop and its features. Useful for users to understand what they are looking at.
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify:
Please proof-read and verify the tutorials.