Skip to content

Comments

Fix intel-laptop target#1728

Merged
brianmcgillion merged 2 commits intotiiuae:mainfrom
nesteroff:fix-intel-laptop
Feb 11, 2026
Merged

Fix intel-laptop target#1728
brianmcgillion merged 2 commits intotiiuae:mainfrom
nesteroff:fix-intel-laptop

Conversation

@nesteroff
Copy link
Contributor

@nesteroff nesteroff commented Feb 4, 2026

Description of Changes

This fixes intel-laptop target and makes the killswitch command work with auto-detected devices.

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

Try building the intel-laptop-debug image and running it on laptops supported by Ghaf.

The killswitch can be tested using the following commands:

ghaf-killswitch list
ghaf-killswitch block cam
ghaf-killswitch unblock cam

@milva-unikie
Copy link

Tested intel-laptop-debug on Darter Pro, Lenovo X1

  • All automated tests passed on both Darter Pro and Lenovo X1.
  • intel-laptop-debug-installer works on X1.
  • Found no issues during a quick manual regression test.

Tested intel-laptop-debug on Dell 7330

  • Dell 7330 does not boot properly. The screen briefly shows the Ghaf logo and then goes black.
  • Ssh connection to net-vm and host work for a moment right after boot, but after a minute the device stops responding even to ping. I was not able to login to host long enough to collect logs.

Considering that without this PR the image does not boot on any target, I approve.

Signed-off-by: Yuri Nesterov <yuriy.nesterov@unikie.com>
Signed-off-by: Yuri Nesterov <yuriy.nesterov@unikie.com>
@nesteroff
Copy link
Contributor Author

Rebased on the latest refactoring and created the intel-laptop-low-mem target for devices with low RAM, such as the Dell 7330.

@brianmcgillion brianmcgillion merged commit 07b41fd into tiiuae:main Feb 11, 2026
32 checks passed
@nesteroff nesteroff deleted the fix-intel-laptop branch February 11, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants