Skip to content

Comments

Post refactor fixup#1747

Merged
brianmcgillion merged 3 commits intotiiuae:mainfrom
kajusnau:post-refactor-fixup
Feb 12, 2026
Merged

Post refactor fixup#1747
brianmcgillion merged 3 commits intotiiuae:mainfrom
kajusnau:post-refactor-fixup

Conversation

@kajusnau
Copy link
Collaborator

@kajusnau kajusnau commented Feb 12, 2026

Description of Changes

  • Re-enable power-manager globally and for gui-vm
  • Revert previous behavior of wait-for-session script in user-login.service
    • After refactoring, user-login.service system service was waiting for a user level target to be reached, which never happened. As a result, gui-vm system status was stuck at "starting".
      What was the idea behind this, maybe something is misunderstood?
  • Re-introduced keep-sorted sorting for laptop targets

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Addresses:

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. Verify bugs listed above are fixed 🔨

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@brianmcgillion brianmcgillion merged commit 7c077e2 into tiiuae:main Feb 12, 2026
32 checks passed
@milva-unikie
Copy link

Confirmed that all the bugs have been fixed. Thank you @kajusnau !

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76 and removed Needs Testing CI Team to pre-verify labels Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants