Skip to content

Comments

Fixup broken refactor#1748

Merged
brianmcgillion merged 7 commits intotiiuae:mainfrom
brianmcgillion:fixup-broken-refactor
Feb 13, 2026
Merged

Fixup broken refactor#1748
brianmcgillion merged 7 commits intotiiuae:mainfrom
brianmcgillion:fixup-broken-refactor

Conversation

@brianmcgillion
Copy link
Collaborator

@brianmcgillion brianmcgillion commented Feb 12, 2026

Description of Changes

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

https://jira.tii.ae/browse/SSRCSP-8005
https://jira.tii.ae/browse/SSRCSP-8006
https://jira.tii.ae/browse/SSRCSP-8007
https://jira.tii.ae/browse/SSRCSP-8016
https://jira.tii.ae/browse/SSRCSP-8019

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. ...

Fixes:SSRCSP-8016

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Fixes: SSRCSP-8007

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Fixes: SSRC-8019

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Fixes: SSRCP-8006

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Fixes: SSRCP-8005

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Copy link
Collaborator

@kajusnau kajusnau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly stylistic if anything

@kajusnau kajusnau requested a review from vunnyso February 13, 2026 08:28
kajusnau

This comment was marked as resolved.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@Gaya-03
Copy link
Collaborator

Gaya-03 commented Feb 13, 2026

Had a quick round of testing with this patch :

https://jira.tii.ae/browse/SSRCSP-8005 - fixed, falcon can be downloaded and working
https://jira.tii.ae/browse/SSRCSP-8006 - partially fixed account gets locked out after wrong password , however , sudo ipset list does not show comms-vm ip as banned.
https://jira.tii.ae/browse/SSRCSP-8007 - fixed , timezone changes can be seen
https://jira.tii.ae/browse/SSRCSP-8016 - storedisk images could be downloaded ( 25 GB detected),loaded, and laptop booted without issues
https://jira.tii.ae/browse/SSRCSP-8019 - do not have a dell laptop , Finland testing team to check.

additionally checked the disk encryption issues also(SSRCSP-8003, SSRCSP-8004), but issues persists and are still not fixed.

@brianmcgillion
Copy link
Collaborator Author

thanks @Gaya-03. removed those encryption changes. and adjusted the PR description to match.

@brianmcgillion brianmcgillion merged commit 39b5538 into tiiuae:main Feb 13, 2026
32 checks passed
@brianmcgillion brianmcgillion deleted the fixup-broken-refactor branch February 13, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants