Skip to content

Comments

Fix interfaces vm#1754

Merged
brianmcgillion merged 2 commits intotiiuae:mainfrom
brianmcgillion:fix-interfaces-vm
Feb 15, 2026
Merged

Fix interfaces vm#1754
brianmcgillion merged 2 commits intotiiuae:mainfrom
brianmcgillion:fix-interfaces-vm

Conversation

@brianmcgillion
Copy link
Collaborator

Description of Changes

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. ...

This is to allow downstream to override it as it necessary for their use
cases. Currently it is fixed and immutable from outside.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
Appvms were using ramMb and cores while the sysvms were using mem and
vcpu. consolidate the naming conventions on mem and vcpu across both
types of vm.

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion brianmcgillion merged commit a806d50 into tiiuae:main Feb 15, 2026
31 of 32 checks passed
@brianmcgillion brianmcgillion deleted the fix-interfaces-vm branch February 15, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants