Github action parallel nix eval#988
Merged
brianmcgillion merged 2 commits intotiiuae:mainfrom Jan 31, 2025
Merged
Conversation
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
00e910f to
ef85b04
Compare
brianmcgillion
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Re-introduce the following changes from #947:
eval.yml, which runs the nix evaluation in parallel, splitting the evaluation to 8 subsets, each of which are executed on a separate github-hosted runner. In testing, this improves the eval action runtime from ~35 minutes down to ~7 minutes.eval.shallows filtering the evaluated targets via the-toption: the initial version in this PR will evaluate all Ghaf flake outputs that match the default filter 'packages.*'.Apparently Ghaf flake does not evaluate with
nix flake show --all-systemsthe way suggested in #947 (comment), which might hint other evaluation problems in Ghaf flake.For now, we need this check to keep the Ghaf flake clear from any (new) evaluation errors.
Checklist for things done
x86_64aarch64riscv64make-checksand it passesnixos-rebuild ... switchInstructions for Testing