Skip to content

Github action parallel nix eval#988

Merged
brianmcgillion merged 2 commits intotiiuae:mainfrom
henrirosten:gh-parallel-nix-eval
Jan 31, 2025
Merged

Github action parallel nix eval#988
brianmcgillion merged 2 commits intotiiuae:mainfrom
henrirosten:gh-parallel-nix-eval

Conversation

@henrirosten
Copy link
Collaborator

@henrirosten henrirosten commented Jan 31, 2025

Description of changes

Re-introduce the following changes from #947:

  • Move the nix evaluation step to its own workflow eval.yml, which runs the nix evaluation in parallel, splitting the evaluation to 8 subsets, each of which are executed on a separate github-hosted runner. In testing, this improves the eval action runtime from ~35 minutes down to ~7 minutes.
  • eval.sh allows filtering the evaluated targets via the -t option: the initial version in this PR will evaluate all Ghaf flake outputs that match the default filter 'packages.*'.

Apparently Ghaf flake does not evaluate with nix flake show --all-systems the way suggested in #947 (comment), which might hint other evaluation problems in Ghaf flake.

For now, we need this check to keep the Ghaf flake clear from any (new) evaluation errors.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

@henrirosten henrirosten temporarily deployed to internal-build-workflow January 31, 2025 11:07 — with GitHub Actions Inactive
@henrirosten henrirosten changed the title Gh parallel nix eval Github action parallel nix eval Jan 31, 2025
@henrirosten henrirosten marked this pull request as ready for review January 31, 2025 11:16
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
@henrirosten henrirosten temporarily deployed to internal-build-workflow January 31, 2025 12:00 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion merged commit f1aa57f into tiiuae:main Jan 31, 2025
22 of 23 checks passed
@henrirosten henrirosten deleted the gh-parallel-nix-eval branch February 11, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants