fix: cherry-pick upstream fix for bootOrder -> initialBootOrder usage#18
Open
Mic92 wants to merge 1 commit into
Open
fix: cherry-pick upstream fix for bootOrder -> initialBootOrder usage#18Mic92 wants to merge 1 commit into
Mic92 wants to merge 1 commit into
Conversation
The xorg package set has been deprecated in nixpkgs. Replace all xorg.libX11, xorg.libXext, xorg.libxcb, etc. references with their new top-level names (libx11, libxext, libxcb, etc.) to silence evaluation warnings like: evaluation warning: The xorg package set has been deprecated, 'xorg.libX11' has been renamed to 'libx11'
Mic92
force-pushed
the
fix/use-initialBootOrder
branch
from
0889b7e to
9000095
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of upstream commit d537752 ("flash-script: Update usage of bootOrder -> intialBootOrder").
Commit c5cd5a0 renamed the option
hardware.nvidia-jetpack.firmware.bootOrdertoinitialBootOrderand added amkRenamedOptionModulecompat alias, but forgot to update two usage sites in the implementation. This causes a trace warning on every evaluation:This was already fixed upstream in anduril/jetpack-nixos@d537752.