fix: Prevent success callback when ShareRequest fails to load. #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a success callback was incorrectly triggered when the ShareRequest encountered an issue and failed to load. This commit fixes the logic to ensure that the success callback is only invoked upon a successful ShareRequest.
This PR addresses an issue where the success callback of the Share API was being triggered even when the ShareRequest failed to load. This was incorrect behavior and led to misleading feedback to the user.
The change involves modifying the ShareApi class to correctly handle the loading state of the ShareRequest. Now, the success callback is only invoked when the ShareRequest has successfully loaded and the sharing process can proceed. If the request fails to load for any reason, an appropriate error or failure state is handled instead.
To test this change:
This change should not have any significant side effects, but it improves the robustness and reliability of the Share API's callback mechanism.