match tsc's behaviour when printing diagnostics context #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octogonz
reviewed
Jun 24, 2025
| @@ -119,6 +119,14 @@ export function findDiagnosticsScopeId(d: DiagnosticTsc, isStrictScope: boolean) | |||
| return `.${results.join('.')}`; | |||
| } | |||
|
|
|||
| // if stdout is being piped to another destination, print diagnostics | |||
| // without pretty colours. This matches the behaviour of TSC: | |||
| // https://github.com/microsoft/TypeScript/blob/0652664e/src/compiler/executeCommandLine.ts#L161 | |||
There was a problem hiding this comment.
Thanks for providing this reference 🙏
There was a problem hiding this comment.
Strange that they tsc considers NO_COLOR=0 to mean no color, but when in Rome 🤷♂️
octogonz
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing diagnostics, the typescript CLI first checks
process.env.NO_COLORand!process.stdout.isTTYto decide whether it should print with colours & context, or not.Currently, this library always uses
ts.formatDiagnosticsWithColorAndContext; so this PR updates the behaviour to match thetscCLI.Test plan:
NO_COLOR=1 …→ it uses the machine-readable formatting… | cat→ it uses the machine-readable formatting