remove useless metric tidb_tikvclient_cop_duration_seconds_bucket #1602

XuHuaiyu · 2025-02-28T09:15:49Z

ti-chi-bot · 2025-02-28T09:15:58Z

Welcome @XuHuaiyu!

It looks like this is your first PR to tikv/client-go 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to tikv/client-go. 😃

Signed-off-by: XuHuaiyu <[email protected]>

Signed-off-by: Lynn <[email protected]>

ti-chi-bot · 2025-03-20T07:45:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: disksing, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [disksing]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-03-20T07:45:02Z

[LGTM Timeline notifier]

Timeline:

2025-03-20 07:44:35.286145449 +0000 UTC m=+514368.970381545: ☑️ agreed by wshwsh12.
2025-03-20 07:45:01.240734976 +0000 UTC m=+514394.924971057: ☑️ agreed by disksing.

XuHuaiyu · 2025-04-03T03:56:53Z

/label needs-cherry-pick-release-6.5
/label needs-cherry-pick-release-7.1
/label needs-cherry-pick-release-7.5
/label needs-cherry-pick-release-8.1
/label needs-cherry-pick-release-8.5

ti-chi-bot · 2025-04-03T03:56:55Z

@XuHuaiyu: The label(s) /label needs-cherry-pick-release-6.5 , /label needs-cherry-pick-release-7.1 , /label needs-cherry-pick-release-7.5 , /label needs-cherry-pick-release-8.1 , /label needs-cherry-pick-release-8.5 cannot be applied. These labels are supported: ``. Is this label configured under labels -> additional_labels or `labels -> restricted_labels` in `plugin.yaml`?

Details

In response to this:

/label needs-cherry-pick-release-6.5
/label needs-cherry-pick-release-7.1
/label needs-cherry-pick-release-7.5
/label needs-cherry-pick-release-8.1
/label needs-cherry-pick-release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

* *: bump pd client (tikv#1575) Signed-off-by: Ryan Leung <[email protected]> * OWNERS: Auto Sync OWNERS files from community membership (tikv#1576) Signed-off-by: Ti Chi Robot <[email protected]> * sync etcd endpoints immediately after initializing the client (tikv#1573) Signed-off-by: Vlad Dmitriev <[email protected]> * p-dml: resolve locks concurrently (tikv#1584) close tikv#1577 Signed-off-by: you06 <[email protected]> * memdb: prevent iterator invalidation (tikv#1563) ref pingcap/tidb#59153 Signed-off-by: ekexium <[email protected]> * locate: refactor RegionRequestSender.SendReqCtx (tikv#1565) Signed-off-by: zyguan <[email protected]> * locate: fix the default settings of circuit breaker (tikv#1593) ref tikv/pd#8678 Signed-off-by: Ryan Leung <[email protected]> * util: define and implement core interfaces for async api (tikv#1591) ref tikv#1586 Signed-off-by: zyguan <[email protected]> * Add a retry when getting ts from PD for validating read ts (tikv#1600) Signed-off-by: MyonKeminta <[email protected]> * pdclient: Add caller info to pd client (tikv#1516) ref tikv/pd#8593 Signed-off-by: okJiang <[email protected]> * locate: fix TestTiKVClientReadTimeout (tikv#1601) Signed-off-by: zyguan <[email protected]> * *: update pd client (tikv#1605) Signed-off-by: Ryan Leung <[email protected]> * Validate ts only for stale read (tikv#1607) ref pingcap/tidb#59402 Signed-off-by: ekexium <[email protected]> * execdetails: export scheduler write details (tikv#1606) Signed-off-by: Neil Shen <[email protected]> * Update pd client (tikv#1615) Signed-off-by: disksing <[email protected]> * ci: allow use label to skip integration tests (tikv#1616) Signed-off-by: disksing <[email protected]> * remove useless metric tidb_tikvclient_cop_duration_seconds_bucket (tikv#1602) Signed-off-by: XuHuaiyu <[email protected]> * client: implement SendRequestAsync for RPCClient (tikv#1604) ref tikv#1586 Signed-off-by: zyguan <[email protected]> * execdetails: export grpc process and wait time to time details (tikv#1614) Signed-off-by: Neil Shen <[email protected]> Co-authored-by: Bisheng Huang <[email protected]> * Refine pessimistic lock related metrics and stats (tikv#1620) Signed-off-by: yibin87 <[email protected]> * metrics: adjust bucket count to reduce metrics data (tikv#1609) Signed-off-by: Lynn <[email protected]> * update tidb for integration tests (tikv#1621) Signed-off-by: disksing <[email protected]> * support redact key in logs (tikv#1612) ref pingcap/tidb#59279 Signed-off-by: tangenta <[email protected]> Co-authored-by: you06 <[email protected]> * update integration_test/go.mod (tikv#1624) Signed-off-by: tangenta <[email protected]> * memdb: introduce snapshot interface (tikv#1623) Signed-off-by: you06 <[email protected]> Co-authored-by: ekexium <[email protected]> * pd: enable OutputMustContainAllKeyRange (tikv#1632) Signed-off-by: lhy1024 <[email protected]> * Fix backoff lose info when forked (tikv#1627) ref pingcap/tidb#60271 Signed-off-by: yibin87 <[email protected]> * tikv: disable health-feedback in next-gen (tikv#1635) Signed-off-by: zyguan <[email protected]> * enable ts validation for normal read (tikv#1619) Signed-off-by: ekexium <[email protected]> * Add txn write conflict metrics (tikv#1551) close tikv#1550 Signed-off-by: sujuntao <[email protected]> Co-authored-by: sujuntao <[email protected]> * apicodec: fix a typo when encoding request for CmdMvccGetByKey (tikv#1638) Signed-off-by: tiancaiamao <[email protected]> Co-authored-by: cfzjywxk <[email protected]> * *: update kvproto version (tikv#1636) ref tikv#1631 Signed-off-by: Chao Wang <[email protected]> * txn: provide more information in commit RPC / log mvcc debug info when commit failed for `TxnLockNotFound` (tikv#1640) ref tikv#1631 Signed-off-by: Chao Wang <[email protected]> * txn: handle undetermined error in client go (tikv#1642) close tikv#1641 Signed-off-by: Chao Wang <[email protected]> * txn: fix the implemention of undetermined error (tikv#1644) close tikv#1641 Signed-off-by: Chao Wang <[email protected]> * locate: implement SendReqAsync for RegionRequestSender (tikv#1618) ref tikv#1586 Signed-off-by: zyguan <[email protected]> * update pd client for resource group and keyspace (tikv#1645) Signed-off-by: lhy1024 <[email protected]> * tests: bump tidb to fix integration tests (tikv#1650) Signed-off-by: zyguan <[email protected]> * Fix some metrics that miss const labels (tikv#1652) Signed-off-by: yibin87 <[email protected]> * Replace etcd safe point with txn safe point for read safety check (tikv#1634) Signed-off-by: MyonKeminta <[email protected]> * Fix stale read metrics (tikv#1649) close tikv#1648 Signed-off-by: you06 <[email protected]> * *: support async batch get (tikv#1646) ref tikv#1586 Signed-off-by: zyguan <[email protected]> * Update kvproto dependancy and set keyspace name for rpc context (tikv#1667) close tikv#1668 Signed-off-by: yibin87 <[email protected]> * ci: add next-gen integration tests (tikv#1661) Signed-off-by: ekexium <[email protected]> * snapshot: set `ReplicaRead` to false when `ReplicaReadType` fallbacks to `ReplicaReadLeader` (tikv#1663) ref pingcap/tidb#61745 Signed-off-by: you06 <[email protected]> * resource_control: support collecting cross AZ traffic in ru consumption (tikv#1669) Signed-off-by: glorv <[email protected]> * txnkv: prevent some actions from being interrupted by kill (tikv#1665) fix pingcap/tidb#61454 Signed-off-by: zyguan <[email protected]> * region_cache: add ForceRefreshAllStores function (tikv#1686) Signed-off-by: guo-shaoge <[email protected]> * upgrade gRPC to allow consumption by peerdb * Bump gprc version to 1.73.0 Remove references to `grpc.NewSharedBufferPool()`, it was removed from the grpc package and causes build to fail - it's always on. (https://pkg.go.dev/google.golang.org/grpc/experimental#WithBufferPool) Signed-off-by: Tiago Scolari <[email protected]> * go mod tidy --------- Signed-off-by: Ryan Leung <[email protected]> Signed-off-by: Ti Chi Robot <[email protected]> Signed-off-by: Vlad Dmitriev <[email protected]> Signed-off-by: you06 <[email protected]> Signed-off-by: ekexium <[email protected]> Signed-off-by: zyguan <[email protected]> Signed-off-by: MyonKeminta <[email protected]> Signed-off-by: okJiang <[email protected]> Signed-off-by: Neil Shen <[email protected]> Signed-off-by: disksing <[email protected]> Signed-off-by: XuHuaiyu <[email protected]> Signed-off-by: yibin87 <[email protected]> Signed-off-by: Lynn <[email protected]> Signed-off-by: tangenta <[email protected]> Signed-off-by: lhy1024 <[email protected]> Signed-off-by: Chao Wang <[email protected]> Signed-off-by: glorv <[email protected]> Signed-off-by: guo-shaoge <[email protected]> Signed-off-by: Tiago Scolari <[email protected]> Co-authored-by: Ryan Leung <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]> Co-authored-by: Vlad Dmitriev <[email protected]> Co-authored-by: you06 <[email protected]> Co-authored-by: ekexium <[email protected]> Co-authored-by: zyguan <[email protected]> Co-authored-by: MyonKeminta <[email protected]> Co-authored-by: okJiang <[email protected]> Co-authored-by: Neil Shen <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: HuaiyuXu <[email protected]> Co-authored-by: Bisheng Huang <[email protected]> Co-authored-by: yibin <[email protected]> Co-authored-by: Lynn <[email protected]> Co-authored-by: tangenta <[email protected]> Co-authored-by: lhy1024 <[email protected]> Co-authored-by: JT <[email protected]> Co-authored-by: sujuntao <[email protected]> Co-authored-by: tiancaiamao <[email protected]> Co-authored-by: cfzjywxk <[email protected]> Co-authored-by: 王超 <[email protected]> Co-authored-by: glorv <[email protected]> Co-authored-by: guo-shaoge <[email protected]> Co-authored-by: Kevin Biju <[email protected]> Co-authored-by: Tiago Scolari <[email protected]>

Signed-off-by: Lynn <[email protected]>

XuHuaiyu · 2025-07-09T09:28:34Z

/cherry-pick tidb-7.5
/cherry-pick tidb-8.1
/cherry-pick tidb-8.5

ti-chi-bot · 2025-07-09T09:29:12Z

@XuHuaiyu: new pull request created to branch tidb-7.5: #1708.

Details

In response to this:

/cherry-pick tidb-7.5
/cherry-pick tidb-8.1
/cherry-pick tidb-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2025-07-09T09:29:47Z

@XuHuaiyu: new pull request created to branch tidb-8.1: #1709.

Details

In response to this:

/cherry-pick tidb-7.5
/cherry-pick tidb-8.1
/cherry-pick tidb-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2025-07-09T09:30:23Z

@XuHuaiyu: new pull request created to branch tidb-8.5: #1710.

Details

In response to this:

/cherry-pick tidb-7.5
/cherry-pick tidb-8.1
/cherry-pick tidb-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

) (#1710) Signed-off-by: XuHuaiyu <[email protected]> Co-authored-by: XuHuaiyu <[email protected]>

) (#1708) Signed-off-by: XuHuaiyu <[email protected]> Co-authored-by: XuHuaiyu <[email protected]>

ti-chi-bot bot added dco-signoff: no Indicates the PR's author has not signed dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2025

remove useless metric tidb_tikvclient_cop_duration_seconds_bucket

7114d83

Signed-off-by: XuHuaiyu <[email protected]>

XuHuaiyu force-pushed the remove_useless_metrics branch from be2631c to 7114d83 Compare February 28, 2025 09:20

ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Feb 28, 2025

This was referenced Feb 28, 2025

infoschema,metrics: use tidb_tikvclient_request_seconds_bucket to get the .999 cop req duration instead pingcap/tidb#59845

Merged

remove some useless metrics pingcap/tidb#59815

Open

zimulala added a commit to zimulala/client-go that referenced this pull request Mar 12, 2025

metrics: tikv#1602 remove cop_duration_seconds, so we needn't do it

14f502d

ti-chi-bot bot mentioned this pull request Mar 12, 2025

metrics: adjust bucket count to reduce metrics data #1609

Merged

zimulala added a commit to zimulala/client-go that referenced this pull request Mar 12, 2025

metrics: tikv#1602 remove cop_duration_seconds, so we needn't do it

daed01b

Signed-off-by: Lynn <[email protected]>

wshwsh12 approved these changes Mar 20, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 20, 2025

disksing approved these changes Mar 20, 2025

View reviewed changes

ti-chi-bot bot added the lgtm label Mar 20, 2025

ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 20, 2025

ti-chi-bot bot merged commit bdaed3e into tikv:master Mar 20, 2025
11 checks passed

ti-chi-bot pushed a commit to ti-chi-bot/client-go that referenced this pull request Jul 9, 2025

metrics: tikv#1602 remove cop_duration_seconds, so we needn't do it

1085e2d

Signed-off-by: Lynn <[email protected]>

ti-chi-bot pushed a commit to ti-chi-bot/client-go that referenced this pull request Jul 9, 2025

metrics: tikv#1602 remove cop_duration_seconds, so we needn't do it

4f1ceaf

Signed-off-by: Lynn <[email protected]>

ti-chi-bot pushed a commit to ti-chi-bot/client-go that referenced this pull request Jul 9, 2025

metrics: tikv#1602 remove cop_duration_seconds, so we needn't do it

f2a24a7

Signed-off-by: Lynn <[email protected]>

ti-chi-bot mentioned this pull request Jul 9, 2025

remove useless metric tidb_tikvclient_cop_duration_seconds_bucket (#1602) #1708

Merged

ti-chi-bot mentioned this pull request Jul 9, 2025

remove useless metric tidb_tikvclient_cop_duration_seconds_bucket (#1602) #1709

Open

ti-chi-bot mentioned this pull request Jul 9, 2025

remove useless metric tidb_tikvclient_cop_duration_seconds_bucket (#1602) #1710

Merged

ti-chi-bot bot pushed a commit that referenced this pull request Jul 9, 2025

remove useless metric tidb_tikvclient_cop_duration_seconds_bucket (#1602

c14b09b

) (#1710) Signed-off-by: XuHuaiyu <[email protected]> Co-authored-by: XuHuaiyu <[email protected]>

ti-chi-bot bot pushed a commit that referenced this pull request Jul 22, 2025

remove useless metric tidb_tikvclient_cop_duration_seconds_bucket (#1602

d40b4b9

) (#1708) Signed-off-by: XuHuaiyu <[email protected]> Co-authored-by: XuHuaiyu <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

remove useless metric tidb_tikvclient_cop_duration_seconds_bucket #1602

remove useless metric tidb_tikvclient_cop_duration_seconds_bucket #1602

Uh oh!

XuHuaiyu commented Feb 28, 2025

Uh oh!

ti-chi-bot bot commented Feb 28, 2025

Uh oh!

ti-chi-bot bot commented Mar 20, 2025

Uh oh!

ti-chi-bot bot commented Mar 20, 2025

Uh oh!

Uh oh!

XuHuaiyu commented Apr 3, 2025

Uh oh!

ti-chi-bot bot commented Apr 3, 2025

Uh oh!

XuHuaiyu commented Jul 9, 2025

Uh oh!

ti-chi-bot commented Jul 9, 2025

Uh oh!

ti-chi-bot commented Jul 9, 2025

Uh oh!

ti-chi-bot commented Jul 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

remove useless metric tidb_tikvclient_cop_duration_seconds_bucket #1602

remove useless metric tidb_tikvclient_cop_duration_seconds_bucket #1602

Uh oh!

Conversation

XuHuaiyu commented Feb 28, 2025

Uh oh!

ti-chi-bot bot commented Feb 28, 2025

Uh oh!

ti-chi-bot bot commented Mar 20, 2025

Uh oh!

ti-chi-bot bot commented Mar 20, 2025

[LGTM Timeline notifier]

Uh oh!

Uh oh!

XuHuaiyu commented Apr 3, 2025

Uh oh!

ti-chi-bot bot commented Apr 3, 2025

Uh oh!

XuHuaiyu commented Jul 9, 2025

Uh oh!

ti-chi-bot commented Jul 9, 2025

Uh oh!

ti-chi-bot commented Jul 9, 2025

Uh oh!

ti-chi-bot commented Jul 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants