locate: retry on ErrClientGetResourceGroup for transient errors #1775
+64
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When receiving ErrClientGetResourceGroup error, distinguish between permanent and transient errors: - For 'resource group not found' error, return directly without retry since it's a permanent error - For other errors (e.g., 'not leader'), apply backoff and retry since they are transient errors Add test case TestOnSendFailByResourceGroupError to cover both scenarios: 1. Test that 'resource group not found' returns immediately without backoff 2. Test that other errors trigger retry with backoff Signed-off-by: disksing <[email protected]>
ti-chi-bot
bot
added
dco-signoff: yes
ystaticy
approved these changes
Oct 22, 2025
|
@ystaticy: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
iosmanthus
approved these changes
Oct 22, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iosmanthus, ystaticy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving ErrClientGetResourceGroup error, distinguish between permanent and transient errors:
Add test case TestOnSendFailByResourceGroupError to cover both scenarios: